-
Notifications
You must be signed in to change notification settings - Fork 78
Update to oauth2 package README for Flutter Web info #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dffe5ac to
c5f215a
Compare
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
c5f215a to
b7a4743
Compare
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
209b4c4 to
6d5fef3
Compare
|
@AbgarSim Just a friendly ping as I am looking through PRs - is there intention to land this? Maybe some from @dart-lang/dart-pub-team has time for a review? |
Co-authored-by: Sigurd Meldgaard <[email protected]>
Co-authored-by: Sigurd Meldgaard <[email protected]>
Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/f4fbac4..6a8746e): 6a8746e 2025-10-13 Moritz Use newest verion of firehose in publish (dart-lang/ecosystem#378) http (https://github.com/dart-lang/http/compare/2c53fa3..2cb6c12): 2cb6c12 2025-10-15 Brian Quinlan chore(cronet_http): Prepare to release 1.6.0 (dart-lang/http#1833) a906598 2025-10-16 Denys Vitali fix(ok_http): trust manager init (dart-lang/http#1830) 54dfd63 2025-10-15 Brian Quinlan docs(cupertino_http): Clarify that happens when a request is cancelled (dart-lang/http#1834) 3e3c366 2025-10-15 Brian Quinlan chore(okhttp): Fix CI by setting minSdk=24 (dart-lang/http#1835) 6271faf 2025-10-13 Benjamin feat: export MediaType from http_parser (dart-lang/http#1803) 32dee0c 2025-10-13 Benjamin chore(cronet_http): bump compileSdkVersion to 34 (dart-lang/http#1832) tools (https://github.com/dart-lang/tools/compare/adf3fe7..f5920a2): f5920a2d 2025-10-16 Morgan :) Fix `PollingDirectoryWatcher` for delete during poll. (dart-lang/tools#2212) 289ba0d3 2025-10-15 Morgan :) Add DirectoryWatcher symlink tests. (dart-lang/tools#2206) 1275d4c3 2025-10-14 Kevin Moore Bump deps for graphs, html, process, pubspec_parse (dart-lang/tools#2210) 8b9a48ca 2025-10-14 Morgan :) Fix test handling of link timestamps. (dart-lang/tools#2208) 81588f32 2025-10-14 Abgar Simonean Update to oauth2 package README for Flutter Web info (dart-lang/tools#1961) webdev (https://github.com/dart-lang/webdev/compare/186bfe7..2517aa9): 2517aa94 2025-10-13 Srujan Gaddam [DWDS] Make pause a no-op on WebSocketProxyService (dart-lang/webdev#2697) Change-Id: Ifee5e199cf5799aa5962639e686192874f4d58b3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455480 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
Description:
This PR updates the README file of oauth2 package relating to the listen and redirect section. The reason being even though the provided information underlines that both listen and redirect are not the scopes of this library the provided example is both obsolete (uni_links is discontinued for app_links) and does not include Flutter Web ( neither web_views nor app_links can be used to implement the flow). As such I believe it could be useful to have a section mentioning how to use this library with Web.
There was an issue opened for this but the solution is still a bit unclear nor is it documented anywhere: #350
Solution