Allow exceptions from operator == #2543
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's confusing to treat an object that throws from `operator ==` identically to one that returns `false` normally. Intentional exceptions in `operator ==` are very unlikely, so this change is not likely to cause spurious failures.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
kevmoo
approved these changes
Sep 18, 2025
|
There are only a few errors internally that I will fix before landing this. I think we should go forward with this even though there is a small risk to the ecosystem for newly failing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's confusing to treat an object that throws from
operator ==identically to one that returns
falsenormally. Intentional exceptionsin
operator ==are very unlikely, so this change is not likely tocause spurious failures.