Serve dart2wasm source map files #2532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart2wasm generates a source map file at the same location with the .wasm file. Serve it to help with debugging in the browser with `--pause-after-load`. Note: somehow the source map file is not requested by the browser when testing with just `test -p chrome -c dart2wasm` (without `--pause-after-load` and manually adding breakpoints). I'm investigating why the source map isn't requested by default.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
sigurdm
approved these changes
Aug 26, 2025
|
CI failure seems unrelated, #2529 also has the same failure. Should I merge this? |
|
Yeah, seems to be failing at main as well Probably fine to merge |
10 tasks
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 8, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. test (https://github.com/dart-lang/test/compare/5aef971..b99d556): b99d556 2025-09-01 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/test#2534) abe4939b 2025-08-27 Nate Bosch Remove executable argument forwarding in tests (dart-lang/test#2533) 81e0579c 2025-08-26 Ömer Sinan Ağacan Serve dart2wasm source map files (dart-lang/test#2532) 9354f239 2025-08-07 Liam Appelbe Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517) Change-Id: I7297cc534d03de343218c829a8e94d70ba35a023 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448423 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 10, 2025
This reverts commit caece5d. Reason for revert: broke Flutter build (dart-lang/test#2517 (comment)) Original change's description: > [deps] rev test > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > test (https://github.com/dart-lang/test/compare/5aef971..b99d556): > b99d556 2025-09-01 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/test#2534) > abe4939b 2025-08-27 Nate Bosch Remove executable argument forwarding in tests (dart-lang/test#2533) > 81e0579c 2025-08-26 Ömer Sinan Ağacan Serve dart2wasm source map files (dart-lang/test#2532) > 9354f239 2025-08-07 Liam Appelbe Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517) > > Change-Id: I7297cc534d03de343218c829a8e94d70ba35a023 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448423 > Auto-Submit: Devon Carew <[email protected]> > Reviewed-by: Konstantin Shcheglov <[email protected]> > Commit-Queue: Konstantin Shcheglov <[email protected]> Change-Id: I5404155f0de9330d37ff74741dd64a1a8d0436d2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448906 Reviewed-by: Alexander Aprelev <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart2wasm generates a source map file at the same location with the .wasm file. Serve it to help with debugging in the browser with
--pause-after-load.Note: somehow the source map file is not requested by the browser when testing with just
test -p chrome -c dart2wasm(without--pause-after-loadand manually adding breakpoints). I'm investigating why the source map isn't requested by default. When I run the same failing test with-c dart2jsthe source map is used.