Skip to content

try to fix windows failures #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024
Merged

try to fix windows failures #2244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9af445
try to fix windows failures
jakemac53 Jun 10, 2024
80dafe2
update changelog
jakemac53 Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/test_core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 0.6.5-wip

* Increase SDK constraint to ^3.4.0.
* Ensure we don't create files ending in a `.`, this breaks windows.

## 0.6.4

Expand Down
2 changes: 1 addition & 1 deletion pkgs/test_core/lib/src/runner/package_version.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ Future<String> get rootPackageLanguageVersionComment =>
final _rootPackageLanguageVersionComment = DetachingFuture(() async {
var packageConfig = await loadPackageConfigUri(await packageConfigUri);
var rootPackage = packageConfig.packageOf(Uri.file(p.absolute('foo.dart')));
if (rootPackage == null) return '';
if (rootPackage == null) return '// <unknown-language-version>';
return '// @dart=${rootPackage.languageVersion}';
}());