Skip to content

Expand the doc comment for Context #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Feb 6, 2023
Merged

Expand the doc comment for Context #1902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8ab184b
Make `label` arguments take callbacks
natebosch Feb 3, 2023
7a0724f
Expand the doc comment for Context
natebosch Feb 3, 2023
10e6f47
Compare the non-nesting label case to a clause directly
natebosch Feb 3, 2023
bac2b3e
Mention that which can be omitted
natebosch Feb 3, 2023
4e4cf10
Enforce single string still in root ctor
natebosch Feb 4, 2023
00888e6
Rename _StringClause to _ExpectationClause
natebosch Feb 4, 2023
308b13d
Update docs for nest and nestAsync
natebosch Feb 4, 2023
e35574b
Consistently use double quotes to avoid escape single quote
natebosch Feb 4, 2023
915652d
Merge commit 'e35574bb' into label-callback--context-docs
natebosch Feb 4, 2023
511fa70
Merge branch 'master' into label-callback--context-docs
natebosch Feb 4, 2023
911659b
Attempt to present information in a better order
natebosch Feb 4, 2023
547abd3
More wording tweaks, add doc header on ConditionSubject
natebosch Feb 4, 2023
ef6bd7e
More wording tweaks and a paragraph on softCheck subjects
natebosch Feb 4, 2023
99f9e2f
Move the 'should not throw' phrase into a template that is used in th…
natebosch Feb 4, 2023
3ca1aaf
Make the fields of Extracted private
natebosch Feb 4, 2023
db4fc6f
More working tweaks, export ConditionSubject
natebosch Feb 4, 2023
b33a327
Merge branch 'master' into label-callback--context-docs
natebosch Feb 4, 2023
330c3f6
Expectation extension method in Subject doc
natebosch Feb 4, 2023
4d14182
missing word
natebosch Feb 6, 2023
6a8e670
Link to example extensions, expand callback phrasing
natebosch Feb 6, 2023
afc09b3
Link the specific methods earlier
natebosch Feb 6, 2023
148ef9d
Move section on callbacks being unused to much later
natebosch Feb 6, 2023
bae48cb
Add some examples
natebosch Feb 6, 2023
e09f2ae
Revert mistaken change
natebosch Feb 6, 2023
b9b8960
Merge branch 'master' into label-callback--context-docs
natebosch Feb 6, 2023
830bdd4
typo
natebosch Feb 6, 2023
fca6584
Merge branch 'master' into label-callback--context-docs
natebosch Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/checks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ extension CustomChecks on Subject<CustomType> {
}

Subject<Foo> get someDerivedValue =>
context.nest('has someDerivedValue', (actual) {
context.nest(() => ['has someDerivedValue'], (actual) {
if (_cannotReadDerivedValue(actual)) {
return Extracted.rejection(which: ['cannot read someDerivedValue']);
}
Expand Down
3 changes: 2 additions & 1 deletion pkgs/checks/lib/context.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@

export 'src/checks.dart'
show
Subject,
CheckFailure,
Condition,
ConditionSubject,
Context,
ContextExtension,
Extracted,
FailureDetail,
Rejection,
Subject,
describe,
describeAsync,
softCheck,
Expand Down
Loading