Skip to content

Conversation

@natebosch
Copy link
Member

The auto-publish comment already indicates that the package name prefix
should be used.

The auto-publish comment already indicates that the package name prefix
should be used.
@natebosch natebosch requested a review from devoncarew May 4, 2023 20:28
@github-actions
Copy link

github-actions bot commented May 4, 2023

Package publishing

Package Version Status Publish tag
package:source_gen 1.3.0 ready to publish (merge and tag to publish) source_gen-v1.3.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@natebosch natebosch merged commit de29956 into master May 5, 2023
@natebosch natebosch deleted the use-prefix-for-autopublish branch May 5, 2023 01:55
@devoncarew
Copy link
Contributor

We really only need to use prefix tags for packages in mono repos; v1.2.3 for single package repos, and my_name-v1.2.3 for packages in mono-repos (https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose#mono-repos).

@natebosch
Copy link
Member Author

We really only need to use prefix tags for packages in mono repos

How does it pick the "Publish Tag' it adds to the comments - that is showing with the package prefix.

We've been using a package prefix in this repo for a while now, though I don't remember the reason why we started that pattern.

@devoncarew
Copy link
Contributor

It figures out whether its in a mono repo or not, and expects one form of the tag or the other:

https://github.com/dart-lang/ecosystem/blob/main/pkgs/firehose/lib/src/repo.dart#L61

We can make this configurable if necessary - we'd just have to figure out the best way to do that (a yaml file in the repo? an arg to the publish task - https://github.com/dart-lang/source_gen/blob/master/.github/workflows/publish.yaml?)

mosuem pushed a commit to dart-lang/build that referenced this pull request Dec 10, 2024
The auto-publish comment already indicates that the package name prefix
should be used.
mosuem pushed a commit to dart-lang/build that referenced this pull request Dec 10, 2024
The auto-publish comment already indicates that the package name prefix
should be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants