Skip to content

KeywordToken: Change keyword field to a getter over type #56435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gmpassos
Copy link
Contributor

Reduce KeywordToken memory usage by changing the keyword field to a getter over type as Keyword.


  • [✅] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Reduce `KeywordToken` memory usage by changing the `keyword` field to a getter over `type as Keyword`.
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/379980

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@mraleph
Copy link
Member

mraleph commented Aug 12, 2024

Please see https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8739802134420221793/+/u/analyze_pkg_/stdout for a build failure which blocked landing.

Copy link

https://dart-review.googlesource.com/c/sdk/+/379980 has been updated with the latest commits from this pull request.

@gmpassos
Copy link
Contributor Author

gmpassos commented Aug 12, 2024

... a build failure which blocked landing.

Fixed analyzer warning (now using super parameters) 👍

@kevmoo
Copy link
Member

kevmoo commented Aug 12, 2024

Nice find, @gmpassos !

@gmpassos
Copy link
Contributor Author

gmpassos commented Aug 13, 2024

@kevmoo

I'm conducting some optimization experiments with the analyzer and analysis_server packages, BTW:
https://github.com/gmpassos/sdk/tree/optimize-analyzer

If I achieve any significant improvements, I will submit a PR.

Thanks, everyone, for the quick merge!

@gmpassos
Copy link
Contributor Author

gmpassos commented Aug 13, 2024

@kevmoo @mraleph

FYI:
https://github.com/gmpassos/sdk/tree/optimize-analyzer

I'm still validating the optimizations with real world projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants