Skip to content

dart2js: split getInterceptor calls out of HIs and HTypeGuard #9732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rakudrama opened this issue Apr 7, 2013 · 8 comments
Closed

dart2js: split getInterceptor calls out of HIs and HTypeGuard #9732

rakudrama opened this issue Apr 7, 2013 · 8 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Milestone

Comments

@rakudrama
Copy link
Member

Some type test instructions are directly generating calls to getInterceptor.
These calls should be broken out of type tests as separate HInterceptor instruction to enable all the interceptor optimizations.

This means that many type tests will now have control flow.

@kasperl
Copy link

kasperl commented Apr 22, 2013

Added this to the Later milestone.

@rakudrama
Copy link
Member Author

Marked this as blocking #9971.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@rakudrama
Copy link
Member Author

Marked this as blocking #13955.

@kasperl
Copy link

kasperl commented Oct 30, 2013

Nicolas, do you have any cycles to try to help address this? I'm mostly worried about this issue blocking issue #13955. I'll assign issue #9726 to you too so you can take a look at the overall issue.


Set owner to [email protected].
Removed this from the Later milestone.
Added this to the M8 milestone.
Removed Priority-Medium label.
Added Priority-High label.

@DartBot
Copy link

DartBot commented Oct 30, 2013

This comment was originally written by [email protected]


This was fixed for a long time. What is not implemented is an optimization to pass the interceptor to cast and checked mode helpers. I filed https://code.google.com/p/dart/issues/detail?id=14630 for that.


Added Fixed label.

@DartBot
Copy link

DartBot commented Oct 30, 2013

This comment was originally written by [email protected]


Unmarked this as blocking #13955.

@rakudrama rakudrama added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Oct 30, 2013
@rakudrama rakudrama added this to the M8 milestone Oct 30, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Development

No branches or pull requests

3 participants