-
Notifications
You must be signed in to change notification settings - Fork 1.7k
dart2js: split getInterceptor calls out of HIs and HTypeGuard #9732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Added this to the Later milestone. |
Marked this as blocking #9971. |
Added TriageForM5 label. |
Removed TriageForM5 label. |
Marked this as blocking #13955. |
Nicolas, do you have any cycles to try to help address this? I'm mostly worried about this issue blocking issue #13955. I'll assign issue #9726 to you too so you can take a look at the overall issue. Set owner to [email protected]. |
This comment was originally written by [email protected] This was fixed for a long time. What is not implemented is an optimization to pass the interceptor to cast and checked mode helpers. I filed https://code.google.com/p/dart/issues/detail?id=14630 for that. Added Fixed label. |
This comment was originally written by [email protected] Unmarked this as blocking #13955. |
Some type test instructions are directly generating calls to getInterceptor.
These calls should be broken out of type tests as separate HInterceptor instruction to enable all the interceptor optimizations.
This means that many type tests will now have control flow.
The text was updated successfully, but these errors were encountered: