-
Notifications
You must be signed in to change notification settings - Fork 1.7k
dart2js: make type tests fully use interceptors #9726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Marked this as blocking #9728. |
Marked this as blocking #9731. |
Marked this as blocking #9732. |
Added this to the Later milestone. |
Added TriageForM5 label. |
Removed TriageForM5 label. |
Assigning to Nicolas to get a feel for how quickly this can be addressed. Set owner to [email protected]. |
This comment was originally written by [email protected] This was fixed for a long time, we create a HInterceptor ssa node that gets removed by the SSA optimizers if the type check does not need it. Added Fixed label. |
Several places have this pattern of type test:
(typeof x == "function" ? x : $.getInterceptor(x)).$isFooCallback()
The root cause is Issue #9586.
Once 9586 is fixed, we should be able replace the above with:
$.getInterceptor(x).$isFooCallback()
The text was updated successfully, but these errors were encountered: