Skip to content

dart2js: make type tests fully use interceptors #9726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rakudrama opened this issue Apr 7, 2013 · 8 comments
Closed

dart2js: make type tests fully use interceptors #9726

rakudrama opened this issue Apr 7, 2013 · 8 comments
Milestone

Comments

@rakudrama
Copy link
Member

Several places have this pattern of type test:

(typeof x == "function" ? x : $.getInterceptor(x)).$isFooCallback()

The root cause is Issue #9586.
Once 9586 is fixed, we should be able replace the above with:

$.getInterceptor(x).$isFooCallback()

@rakudrama
Copy link
Member Author

Marked this as blocking #9728.

@rakudrama
Copy link
Member Author

Marked this as blocking #9731.

@rakudrama
Copy link
Member Author

Marked this as blocking #9732.

@kasperl
Copy link

kasperl commented Apr 22, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Oct 30, 2013

Assigning to Nicolas to get a feel for how quickly this can be addressed.


Set owner to [email protected].
Removed this from the Later milestone.
Added this to the M8 milestone.

@DartBot
Copy link

DartBot commented Oct 30, 2013

This comment was originally written by [email protected]


This was fixed for a long time, we create a HInterceptor ssa node that gets removed by the SSA optimizers if the type check does not need it.


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants