Skip to content

dart2js: remove type test hooks from Object.prototype #9728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rakudrama opened this issue Apr 7, 2013 · 3 comments
Closed

dart2js: remove type test hooks from Object.prototype #9728

rakudrama opened this issue Apr 7, 2013 · 3 comments
Labels
web-dart2js

Comments

@rakudrama
Copy link
Member

dart2js places functions like

   $isFoo: function(){return false}

on Object.prototype. This happens when there are native classes so that type tests work on native classes, holders, raw objects and static functions. All these cases should be handled by other means - using classes instead of holders, or using interceptors.
@rakudrama
Copy link
Member Author

Marked this as blocking #9729.

@rakudrama
Copy link
Member Author

https://codereview.chromium.org/14015004

Added Started label.

@rakudrama
Copy link
Member Author

Fixed r21578

Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rakudrama