Skip to content

coveralls and new void assignment semantics breaking the build #57751

@pq

Description

@pq

Issues w/ void semantics (#33934) and coveralls are breaking the linter build.

Failed to precompile dart_coveralls:dart_coveralls:
file:///home/travis/.pub-cache/hosted/pub.dartlang.org/dart_coveralls-0.6.0+1/bin/src/report.dart:16:29: Error: This expression has type 'void' and can't be used.
    if (res["help"]) return print(parser.usage);
                            ^
file:///home/travis/.pub-cache/hosted/pub.dartlang.org/dart_coveralls-0.6.0+1/bin/src/report.dart:22:38: Error: This expression has type 'void' and can't be used.
    if (res.rest.length != 1) return print("Please specify a test file to run");
                                     ^
file:///home/travis/.pub-cache/hosted/pub.dartlang.org/dart_coveralls-0.6.0+1/bin/src/report.dart:25:36: Error: This expression has type 'void' and can't be used.
    if (!file.existsSync()) return print("Dart file does not exist");
                                   ^
file:///home/travis/.pub-cache/hosted/pub.dartlang.org/dart_coveralls-0.6.0+1/bin/src/upload.dart:15:29: Error: This expression has type 'void' and can't be used.
    if (res["help"]) return print(parser.usage);
                            ^
file:///home/travis/.pub-cache/hosted/pub.dartlang.org/dart_coveralls-0.6.0+1/bin/src/upload.dart:22:14: Error: This expression has type 'void' and can't be used.
      return print("Please specify a directory containing VM coverage files");
             ^
file:///home/travis/.pub-cache/hosted/pub.dartlang.org/dart_coveralls-0.6.0+1/bin/src/upload.dart:33:14: Error: This expression has type 'void' and can't be used.
      return print("Directory containing VM coverage files does not exist");
             ^

The problematic change has been reverted (5c9c90f). Once a new SDK has been pushed we can kick the build and 🤞 .

/cc @MichaelRFairhurst @kevmoo

Metadata

Metadata

Assignees

No one assigned

    Labels

    devexp-linterIssues with the analyzer's support for the linter packagelegacy-area-analyzerUse area-devexp instead.type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions