Discontinue `dartanalyzer`

[mit-mit]

As part of the transition to the new unified dart developer tool, we're discontinuing dartanalyzer in favor of dart analyze. This issue tracks remaining clean-up items needed to fully discontinue dartanalyzer:

• add support for analyzing the Dart SDK libs (currently --dart-sdk=/Users/foo/src/dart-repo/sdk/sdk)
  Add support to dart analyze for analyzing the Dart SDK libraries #48959
• Scrub all occurrences of dartanalyzer in the SDK
• Remove bin/dartanalyzer & bin/snapshots/dartanalyzer.dart.snapshot from the SDK
• Remove package:analyzer_cli from the SDK
• Add support for running with experiments, either via a private build target for dartanalyzer or by supporting experiment flags in dart analyze
  Add support to dart analyze for running with experiments #48960

[eernstg]

Could we make it a action item to support dart analyze --enable-experiment=... as well, or do we have a plan for how to do that in some other way?

[mit-mit]

I think dart --enable-experiment=... analyze works already?

[eernstg]

That would be great! I currently seem to get the following:

> dart --enable-experiment=enhanced-enums analyze n030.dart
Analyzing n030.dart...                 3.4s

  error • n030.dart:2:4 • This requires the 'enhanced-enums' language
          feature to be enabled. Try updating your pubspec.yaml to set the
          minimum SDK constraint to 2.17.0 or higher, and running 'pub get'. •
          experiment_not_enabled

1 issue found.
> dart analyze --enable-experiment=enhanced-enums n030.dart  
Could not find an option named "enable-experiment".

Usage: dart analyze [arguments] [<directory>]
-h, --help                   Print this usage information.
    --fatal-infos            Treat info level issues as fatal.
    --[no-]fatal-warnings    Treat warning level issues as fatal.
                             (defaults to on)

Run "dart help" to see global options.

where dart is from commit 19c7f85. There is no package and no pubspec.yaml, maybe that's it?

[mit-mit]

Yes; you need to be on the right language version also, which requires a package config being generated by pub get

[eernstg]

OK, did that. But we're not at 2.17.0 yet (and this dart is from a commit late yesterday afternoon), so following the advice in the emitted message does not seem to work at this point:

> dart pub get
Resolving dependencies... 
The current Dart SDK version is 2.17.0-edge.19c7f85bfe1758d39570feeee3e6aa3ebdc56d90.

Because scratch requires SDK version >=2.17.0 <3.0.0, version solving failed.

[mit-mit]

Try:

environment:
  sdk: '>=2.17.0-0 <3.0.0'

[eernstg]

Still Try updating your pubspec.yaml to set the minimum SDK constraint to 2.17.0 or higher.

[mit-mit]

Sure, but 1) if you had created your project with dart create the pubspec would have had the right constraint, and 2) the message I believe optimizes for the 99%+ fraction of users that use stable releases. In either case, probably better to discuss in a separate issue as that seems entirely orthogonal to the present issue.

[bkonyi]

@bwilkerson @srawlins can one of you take ownership of this? Ideally this would be done for 2.17.

[srawlins]

No promises on the 2.17 bit 😬 but we can triage this.

[bkonyi]

No promises on the 2.17 bit grimacing but we can triage this.

I had a feeling, but that's not the end of the world. 2.18 should be fine :-)