-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
cherry-pick-approvedLabel for approved cherrypick requestLabel for approved cherrypick requestcherry-pick-reviewIssue that need cherry pick triage to approveIssue that need cherry pick triage to approvemerge-to-beta
Milestone
Description
commit(s) to merge: 9cbed61
merge instructions: clean merge
What is the issue: Fix null-safety type bug in HTTP code. Triggers if passing a timeout.
What is the fix: Refactor the code to avoid using null
as a signal that a timeout happened. Catch TimeoutException
instead.
Why cherrypick: It's a bug that prevents all use of the timeout
parameter. It was introduced in null safety migration.
Risk: Very little to none. The fix should not change the behavior of any existing code, except where it would otherwise hit the bug.
Link to original issue(s): #44989
Metadata
Metadata
Assignees
Labels
cherry-pick-approvedLabel for approved cherrypick requestLabel for approved cherrypick requestcherry-pick-reviewIssue that need cherry pick triage to approveIssue that need cherry pick triage to approvemerge-to-beta