-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Make Isolate.spawn work without loading from source in JIT mode #31698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I will try to see how hard this is. |
… a Kernel IR file Issue #31698 Change-Id: Ifc6662a3fd56245c10f5d924f771ef85ed9b222c Reviewed-on: https://dart-review.googlesource.com/34742 Reviewed-by: Vyacheslav Egorov <[email protected]>
The VM can now be launched with a dill file and use The remaining things, regarding not loading it from disc again but rather use the kernel blobs from the spawning isolate as well as supporting spawning from URIs are two other things I don't plan on looking into. |
The rest of work is going to happen under #6610 umbrella, closing this one. |
Currently
Isolate.spawn(func, ...)
simply loads newly spawned isolate from source in JIT mode.In the Dart 2 / Kernel world this seems to be an incorrect / partially working approach, because use cases like running from a dill file are broken as VM attempts to parse code for a newly spawned isolate using a legacy parser.
It seems strange attempt to parse the code again instead of loading it from Kernel binary.
I think we should try to solve this in two steps:
Isolate.spawn(func, ...)
, spawn it from the Kernel binary (if available) that spawned original isolate;/cc @kmillikin @jensjoha @kmillikin
The text was updated successfully, but these errors were encountered: