Skip to content

A bunch of simdbc tests fail after https://dart-review.googlesource.com/c/sdk/+/30389 #31695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
efortuna opened this issue Dec 20, 2017 · 3 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@efortuna
Copy link
Contributor

After https://dart-review.googlesource.com/c/sdk/+/30389 which turned on strong mode for a bunch of vm tests, strangely the simdb64 bots failed on an additional set of tests separate from the other architectures, even though the particular tests shouldn't be arch-specific. Filing bug to investigate.

@efortuna efortuna added area-gardening area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Dec 20, 2017
@rmacnak-google
Copy link
Contributor

@mraleph @mkustermann I suspect these failures are related to batch mode rather than DBC per-se.

@mkustermann
Copy link
Member

Going forward, please do not globally skip huge parts of a test suite, like io/*: Skip.

The new configurations we are testing now, namely dartk-simarm/simarm64/simdbc64 are too slow to run in normal mode, so we run these in batch mode. Currently this implies that isolate spawning doesn't quite work as usual, so we only skip those tests which spawn isolates. A comment explaining this is available in almost any kernel status file.

@mraleph
Copy link
Member

mraleph commented Dec 20, 2017

Yes, these tests (at least some that I looked at) spawn isolates and spawn isolates end up running from source. I see two solutions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

4 participants