-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onlegacy-area-analyzerUse area-devexp instead.Use area-devexp instead.type-code-healthInternal changes to our tools and workflows to make them cleaner, simpler, or more maintainableInternal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Description
I don't know whether this is causing any bugs, but the method Member.baseElement
is being used in a seemingly inconsistent way. It appears that some of the code expects that baseElement
will always return a non-member and that other code is careful to invoke baseElement
until it returns a non-member. The getter, as things are currently implemented, is not required to return a non-member. We should (a) clearly document the expected behavior of the getter (whether the current behavior or a strictly non-member implementation) and (b) check the current invocation sites to make sure they're consistent with the decided on implementation.
Metadata
Metadata
Assignees
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onlegacy-area-analyzerUse area-devexp instead.Use area-devexp instead.type-code-healthInternal changes to our tools and workflows to make them cleaner, simpler, or more maintainableInternal changes to our tools and workflows to make them cleaner, simpler, or more maintainable