-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Flaky: async/timer_regress22626_test appears flaky by design #28254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Added area-vm because the regression test case was added as part of fixing a VM issue. |
Expanding the MIPS-specific flaky marker in the status file to cover all architectures after seeing this on debug-x64 too. See #28254 and the older #22626. [email protected] BUG= Review-Url: https://codereview.chromium.org/2615593002 .
This issue has been open for 315 days. Please consider investigating whether it is still meaningful and if not close it. If the issue is still meaningful please find a relevant owner. Thank you. |
Should we delete the test and close this issue? |
It looks like the test it not always disabled and we are still running it in All status files together:
(Note that #7728 was solved already but the status entry was not deleted.) @mraleph: should I go ahead and create a CL to delete this test? |
Looking at the original issue, that this is a regression test for (#22626), the issue was diagnosed and fixed, and this regression seems so specific that we don't lose much coverage by dropping this test. On the other hand, if the timeout of 200ms in "test(200, 2)" is increased to 2s or more, it should be a passing, never flaky test and could be run everywhere. So a CL dropping it seems ok to me. |
The test case looks flaky and it is (very rarely) causing issues on the build bots. Contrary to the original status file update by @whesse this doesn't appear to happen only on MIPS.
The text was updated successfully, but these errors were encountered: