Skip to content

Flaky: async/timer_regress22626_test appears flaky by design #28254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasperl opened this issue Jan 4, 2017 · 5 comments
Closed

Flaky: async/timer_regress22626_test appears flaky by design #28254

kasperl opened this issue Jan 4, 2017 · 5 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@kasperl
Copy link

kasperl commented Jan 4, 2017

The test case looks flaky and it is (very rarely) causing issues on the build bots. Contrary to the original status file update by @whesse this doesn't appear to happen only on MIPS.

@kasperl kasperl added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jan 4, 2017
@kasperl
Copy link
Author

kasperl commented Jan 4, 2017

Added area-vm because the regression test case was added as part of fixing a VM issue.

kasperl pushed a commit that referenced this issue Jan 4, 2017
Expanding the MIPS-specific flaky marker in the status file to cover all architectures after seeing this on debug-x64 too.

See #28254 and the older
#22626.

[email protected]
BUG=

Review-Url: https://codereview.chromium.org/2615593002 .
@mraleph
Copy link
Member

mraleph commented Nov 16, 2017

This issue has been open for 315 days. Please consider investigating whether it is still meaningful and if not close it. If the issue is still meaningful please find a relevant owner. Thank you.

@mraleph
Copy link
Member

mraleph commented Apr 24, 2018

Should we delete the test and close this issue?

@dcharkes
Copy link
Contributor

dcharkes commented Dec 4, 2018

It looks like the test it not always disabled and we are still running it in $mode = release && $compiler == dartkb.

All status files together:

[ $mode == debug && $hot_reload_rollback && ($compiler == dartk || $compiler == dartkb) ]
async/timer_regress22626_test: Skip # Timing dependent

[ $compiler == app_jit || $compiler == none || $compiler == precompiler ]
...
async/timer_regress22626_test: Pass, RuntimeError # Issue 28254

[ $hot_reload ]
...
async/timer_regress22626_test: Pass, RuntimeError # Timing dependent.

[ $compiler == dart2js && $runtime == jsshell ]
...
async/timer_regress22626_test: RuntimeError # Non-zero timers not supported; Issue 7728.

(Note that #7728 was solved already but the status entry was not deleted.)

@mraleph: should I go ahead and create a CL to delete this test?

@whesse
Copy link
Contributor

whesse commented Dec 4, 2018

Looking at the original issue, that this is a regression test for (#22626), the issue was diagnosed and fixed, and this regression seems so specific that we don't lose much coverage by dropping this test. On the other hand, if the timeout of 200ms in "test(200, 2)" is increased to 2s or more, it should be a passing, never flaky test and could be run everywhere. So a CL dropping it seems ok to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

5 participants