Skip to content

Commit 04b2b75

Browse files
dcharkescommit-bot@chromium.org
authored andcommitted
[Gardening] Remove inherently flaky async/timer_regress22626_test
Closes #28254 Change-Id: I5c1f66a3f22ee7adbb7bc294f1b5a6ffd94637c2 Reviewed-on: https://dart-review.googlesource.com/c/86025 Auto-Submit: Daco Harkes <[email protected]> Reviewed-by: William Hesse <[email protected]> Commit-Queue: William Hesse <[email protected]>
1 parent 089f098 commit 04b2b75

File tree

5 files changed

+0
-39
lines changed

5 files changed

+0
-39
lines changed

tests/lib_2/async/timer_regress22626_test.dart

Lines changed: 0 additions & 35 deletions
This file was deleted.

tests/lib_2/lib_2.status

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ isolate/deferred_in_isolate2_test: Skip # Issue 16898. Deferred loading does not
108108

109109
[ $hot_reload ]
110110
async/stream_periodic4_test: Pass, RuntimeError # Issue 30904
111-
async/timer_regress22626_test: Pass, RuntimeError # Timing dependent.
112111
mirrors/dynamic_load_test: RuntimeError # Issue 26869 - Reload fails to preserve library identity
113112

114113
[ $jscl ]

tests/lib_2/lib_2_dart2js.status

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,6 @@ async/timer_cancel1_test: RuntimeError # Timer interface not supported: Issue 77
456456
async/timer_cancel2_test: RuntimeError # Timer interface not supported: Issue 7728.
457457
async/timer_cancel_test: RuntimeError # Timer interface not supported: Issue 7728.
458458
async/timer_isActive_test: RuntimeError # Timer interface not supported: Issue 7728.
459-
async/timer_regress22626_test: RuntimeError # Non-zero timers not supported; Issue 7728.
460459
async/timer_repeat_test: RuntimeError # Timer interface not supported: Issue 7728.
461460
async/timer_test: RuntimeError # Timer interface not supported: Issue 7728.
462461
async/zone_bind_test: Fail # Timer interface not supported: Issue 7728.

tests/lib_2/lib_2_kernel.status

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ mirrors/native_class_test: CompileTimeError
123123
mirrors/other_declarations_location_test: Crash # Issue 33325 (assertion error, TypeParameter not having position).
124124

125125
[ $mode == debug && $hot_reload_rollback && ($compiler == dartk || $compiler == dartkb) ]
126-
async/timer_regress22626_test: Skip # Timing dependent
127126
isolate/message3_test/constList_identical: Skip # Timeout
128127

129128
[ $runtime == vm && $checked && $strong && ($compiler == dartk || $compiler == dartkb) ]

tests/lib_2/lib_2_precompiled.status

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ async/async_no_await_zones_test: RuntimeError # Issue 33700
1212
[ $compiler == app_jit || $compiler == none || $compiler == precompiler ]
1313
async/future_or_strong_test: RuntimeError
1414
async/timer_not_available_test: SkipByDesign # only meant to test when there is no way to implement timer (currently only in d8)
15-
async/timer_regress22626_test: Pass, RuntimeError # Issue 28254
1615
isolate/compile_time_error_test/01: Skip # Issue 12587
1716
isolate/ping_pause_test: Skip # Resolve test issues
1817
isolate/ping_test: Skip # Resolve test issues

0 commit comments

Comments
 (0)