Skip to content

Names are re-exported when imports have prefixes #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasperl opened this issue Apr 13, 2012 · 4 comments
Closed

Names are re-exported when imports have prefixes #2556

kasperl opened this issue Apr 13, 2012 · 4 comments
Assignees
Labels
closed-obsolete Closed as the reported issue is no longer relevant P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@kasperl
Copy link

kasperl commented Apr 13, 2012

Dart Editor build: 6498
Dart SDK version: 6478

It looks like imports with prefixes are mishandled in the analyzer. The editor happily accepts the following three files, but foo.Bar is not supposed to resolve (this only happens when the import has a prefix).

--- test.dart ---

import('foo.dart', prefix: 'foo');

void main() {
  foo.Bar b = new foo.Bar();
  print(b);
}

--- foo.dart ---

library('foo');

import('bar.dart');

--- bar.dart ---

library('bar');

class Bar {
  toString() => 'bar';
}

@kasperl
Copy link
Author

kasperl commented Apr 17, 2012

Removed Area-Compiler label.
Added Area-Analyzer label.

@danrubel
Copy link

danrubel commented Jun 1, 2012

Is this still a problem?


Set owner to @scheglov.
Removed Area-Analyzer label.
Added Area-Editor label.

@clayberg
Copy link

clayberg commented Jun 1, 2012

Added this to the M1 milestone.

@scheglov
Copy link
Contributor

scheglov commented Jun 1, 2012

Can not reproduce.
It shows error for me, as expected.


Added AssumedStale label.

@kasperl kasperl added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures closed-obsolete Closed as the reported issue is no longer relevant labels Jun 1, 2012
@kasperl kasperl added this to the M1 milestone Jun 1, 2012
dart-bot pushed a commit that referenced this issue Jul 20, 2020
git log --oneline 85bdb898aeb2ac7cea76489ba0bf4e52ff7a79bf..master
04b054b6 Find sdk path with cli_util (#2567)
36c195b9 Only alert about new prereleases for prereleases (#2556)
00b36394 Stop using deprecated mapMap from pkg:collection (#2544)
477cbe72 Improved expectations in flutter_plugin_format validator test (#2532)
a8e2442b `pub run` Don't write about precompilation if no terminal is attached (#2531)
d83d36a4 Don't precompile dependencies of global activate from path (#2530)
870f395c Sanitize git cache folder names (#2522)
03b7f9a5 Avoid divisive terms (#2523)
b239ada4 Remove divisive term (#2517)

Change-Id: I55ea52a86121a382dca5c0f85addd4513ada50bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154940
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

4 participants