Skip to content

Remove folder modal popup isn't necessary #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue Apr 11, 2012 · 6 comments
Closed

Remove folder modal popup isn't necessary #2522

DartBot opened this issue Apr 11, 2012 · 6 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Apr 11, 2012

This issue was originally filed by [email protected]

In general we only need modal popups if something irreversible is about to happen. e.g. delete. Remove from editor doesn't need a modal warning dialog.
@kasperl
Copy link

kasperl commented Apr 11, 2012

Added Area-Editor, Triaged labels.

@bwilkerson
Copy link
Member

Agreed. Furthermore, it should be reversible via "Undo" so that users don't have to navigate through the file system to find the directory to open.

@keertip
Copy link
Contributor

keertip commented Apr 12, 2012

Set owner to @keertip.

@keertip
Copy link
Contributor

keertip commented Apr 12, 2012

removed dialog https://chromiumcodereview.appspot.com/10066022/

Removed the owner.

@clayberg
Copy link

Removed Type-Defect label.
Added Type-Enhancement label.

@danrubel
Copy link

danrubel commented Jun 1, 2012

Added Fixed label.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
dart-bot pushed a commit that referenced this issue Jul 20, 2020
@sigurdm
Bump pub
ad3be0a 
git log --oneline 85bdb898aeb2ac7cea76489ba0bf4e52ff7a79bf..master
04b054b6 Find sdk path with cli_util (#2567)
36c195b9 Only alert about new prereleases for prereleases (#2556)
00b36394 Stop using deprecated mapMap from pkg:collection (#2544)
477cbe72 Improved expectations in flutter_plugin_format validator test (#2532)
a8e2442b `pub run` Don't write about precompilation if no terminal is attached (#2531)
d83d36a4 Don't precompile dependencies of global activate from path (#2530)
870f395c Sanitize git cache folder names (#2522)
03b7f9a5 Avoid divisive terms (#2523)
b239ada4 Remove divisive term (#2517)

Change-Id: I55ea52a86121a382dca5c0f85addd4513ada50bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154940
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @kasperl @keertip @danrubel @bwilkerson @clayberg @DartBot