analyzer/tool/summary/check_test fails on Windows

[whesse]

I am marking it as Fail in the status file pkg/pkg.status.

Output of debug run on the buildbot:
stdout:
File: 'E:\b\build\slave\pkg-win-debug-be\build\sdk\pkg\analyzer\lib\src\summary\format.dart' does not have expected contents.
Please regenerate using:
build\DebugIA32\dart-sdk\bin\dart.exe --package-root=file:///E:/b/build/slave/pkg-win-debug-be/build/sdk/build/DebugIA32/packages/ E:\b\build\slave\pkg-win-debug-be\build\sdk\pkg\analyzer\tool\summary\generate.dart

[whesse]

By the way, would the lines from check_test.dart that say:
String script = Platform.script.toFilePath(windows: Platform.isWindows);
String pkgPath = normalize(join(dirname(script), '..', '..'));

be better as
String pkgPath = Platform.script.resolve('../..').toFilePath()

Resolve takes the filename off, attaches the string, and normalizes.
The default value of the windows: option is Platform.isWindows.

[stereotype441]

Example status file exhibiting the failure: https://build.chromium.org/p/client.dart/builders/pkg-win-be/builds/1495/steps/pkg%20tests/logs/stdio. This build step tested commit f114dc1.

I have been unable to reproduce the failure using a Windows laptop (I tried both commit f114dc1 and the latest commit, which is ba31abe), so I will have to debug this on the buildbot itself.

Unfortunately the buildbot is currently very unreliable (17 of the last 20 builds have failed to build the SDK, so they haven't even gotten to the point of running the test in question). I've filed a bug to track that (#25474)--once it is fixed I will investigate why the buildbot fails this particular test.

[stereotype441]

Bill notes that there is also an FYI bot exhibiting these failures--see https://build.chromium.org/p/client.dart.fyi/builders/pkg-win-be/builds/3/steps/pkg%20tests%20failures/logs/stdio. I will try debugging from there.