Refactor/login #4583
Merged
Refactor/login #4583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the login command logic by retrieving userInfo once at the beginning of the method. This reduces redundancy and improves code readability.
sigurdm
approved these changes
Oct 6, 2025
Contributor
sigurdm
left a comment
sigurdm
left a comment
There was a problem hiding this comment.
Sorry - I totally missed out on this PR.
It looks good to me.
We should probably build some kind of tests of this though...
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Does
This PR refactors the internal login service logic, specifically the runProtected() and _retrieveUserInfo() methods, with the goal of:
Improving code readability and maintainability
Simplifying control flow
Making log messages more actionable and less ambiguous
Handling broken or missing credentials more gracefully
❓ Why I'm creating this PR
While trying to authenticate using dart pub login, I encountered this issue:
you are logged in as nullThis indicated broken or malformed credentials, and the current logging flow was not clear or helpful enough.