Skip to content

Fix null-safety warning in dart.dart #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2022
Merged

Fix null-safety warning in dart.dart #3514

merged 3 commits into from
Aug 22, 2022

Conversation

dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Aug 4, 2022

@dcharkes dcharkes requested a review from jonasfj August 4, 2022 15:37
@sigurdm sigurdm added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Aug 11, 2022
@sigurdm
Copy link
Contributor

sigurdm commented Aug 11, 2022

I think this change has not yet been published in pub.dev: dart-lang/webdev@ab82887#diff-99089b7762498f852485fbc2c7a85c455ba0a793f3756715f47e50ce05ae1ef3L133

cc @jakemac53

@jonasfj jonasfj requested review from sigurdm and removed request for jonasfj August 16, 2022 08:06
@sigurdm
Copy link
Contributor

sigurdm commented Aug 16, 2022

I don't think we can land this until the update of webdev has been published.

@jakemac53
Copy link
Contributor

I can work on publishing that

@jakemac53 jakemac53 mentioned this pull request Aug 16, 2022
Merged
@sigurdm
Copy link
Contributor

sigurdm commented Aug 19, 2022

Now test_core is holding us back. It also depends on frontend_server_client: ^2.1.0

@sigurdm sigurdm mentioned this pull request Aug 19, 2022
Closed
sigurdm
sigurdm approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigurdm sigurdm merged commit ec35d46 into master Aug 22, 2022
@dcharkes
Copy link
Contributor Author

Thanks @sigurdm!

@dcharkes dcharkes deleted the null-safety-warning branch August 22, 2022 11:22
@sigurdm
Copy link
Contributor

sigurdm commented Aug 23, 2022

Hmm seems this is breaking google3 - we probably also need a roll there...
https://fusion2.corp.google.com/invocations/7ebe1e59-a883-4656-bbde-f75160def304/targets/%2F%2Fdart%2Fsdk%2Frapture:dartsdk_deb_test/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcharkes @sigurdm @jakemac53