Use new HTTP retry logic when fetching SDK's index.json + refactor #8711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Apr 29, 2025
| }) async { | ||
| return await retry( | ||
| () async { | ||
| final client = http.Client(); |
There was a problem hiding this comment.
Perhaps we pass in a client instead of creating a new client for every url to fetch?
There was a problem hiding this comment.
Planning to do that in subsequent PRs (when migrating more functions to use this).
The practical difference in this specific case was negligible: we would only call the method when the index.json is not fetched at container creation time (or in local tests).
sigurdm
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchBackend.loadOrFetchSdkIndexJsonAsStringdependence on scope-specific state, moving it out of the backend class, which will make it easier to move the SDK index to a separate isolate (SDK search index improvements (tracking issue) #8670).