Minimal hostname validation on package uploads. #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1081
Manual testing revealed that
pubclient already validates against missing values and values without http(s) prefixes. However it accepted eg.http://, and now we are filtering those too.I think that manually accessing the web page is not a strict requirement at upload time, because it may be that it has a temporary access issue, and I wouldn't block uploads on that. However, it is reasonable to make it part of the package analysis, and give some penalty if the homepage is 404. We have already an open issue for it here: dart-lang/pana#287