Skip to content

Upgrade runtime versions #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2018
Merged

Upgrade runtime versions #1176

merged 1 commit into from
Apr 9, 2018

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Apr 7, 2018 •
edited
Loading

@isoos
Copy link
Collaborator Author

isoos commented Apr 7, 2018

Deploying to staging (with the analyzer fix PR)

@isoos
Copy link
Collaborator Author

isoos commented Apr 9, 2018

Deploying to staging (with the analyzer fix PR)

AFAICT this looks good (including resource use).

jakobr-google
jakobr-google approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isoos isoos merged commit d18cb1d into dart-lang:master Apr 9, 2018
@isoos isoos deleted the upgrade_runtime branch April 9, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jakobr-google jakobr-google jakobr-google approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: Unknown scheme (dart-ext) for dart-ext:src/serial_port Reconfigure pana for all packages to use Dart 2 checks
3 participants
@isoos @jakobr-google @googlebot