Skip to content

Dartdoc customization #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2018
Merged

Dartdoc customization #1005

merged 5 commits into from
Feb 21, 2018

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Feb 21, 2018

The current customization focuses on the page header:

  • The icon goes to pub.dartlang.org
  • The "<pkg_name> pacakge" goes to the pub.dartlang.org/packages//versions/ page
  • The documentation" goes to the generated output's root (index.html)

screen shot 2018-02-21 at 11 03 56


Submitted in separate commits for easier review.

@isoos isoos force-pushed the dartdoc_customization branch from 4d8d025 to d18f9dc Compare February 21, 2018 10:07
Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isoos isoos merged commit 99e2e24 into dart-lang:master Feb 21, 2018
@isoos isoos deleted the dartdoc_customization branch February 21, 2018 12:39
@kevmoo
Copy link
Member

kevmoo commented Feb 23, 2018

FYI @jcollins-g – it might be good for you and @isoos and @jakobr-google to chat about possible tweaks to the dartdoc package. My guess is the package site will be running dartdoc more than anyone else – even the SDK 😄

@jcollins-g
Copy link

jcollins-g commented Feb 23, 2018

This seems suboptimal to do outside of dartdoc itself. If you have particular changes to the header generation you'd like, we should just do it there -- that way all customers of the code get the same thing. Dartdoc has template flags for headers that can be used to do some of this, at least.

@isoos
Copy link
Collaborator Author

isoos commented Feb 23, 2018

Let's collect the requirements in an issue: #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants