Skip to content

Tracking: customization requests from dartdoc tool #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks
isoos opened this issue Feb 23, 2018 · 8 comments
Closed
3 tasks

Tracking: customization requests from dartdoc tool #1019

isoos opened this issue Feb 23, 2018 · 8 comments

Comments

@isoos
Copy link
Collaborator

isoos commented Feb 23, 2018 •
edited
Loading

  • run dartdoc from Dart code (Allow running from Dart code. dartdoc#1609) (importing as a library)
  • custom path for static assets (so we don't need to store it for each package version separately)
  • customization of <header> and breadcrumbs
@isoos isoos mentioned this issue Feb 23, 2018
Merged
@isoos
Copy link
Collaborator Author

isoos commented Feb 23, 2018

@jcollins-g: these are the currently known ones. We plan to do further integration within the pub site, and that may require a different design, so I'd rather postpone the <header> and breadcrumbs parts for now.

@jcollins-g
Copy link

Does the --header command-line option not provide sufficient customization for the header?

The static assets request could probably be filed as its own issue. I welcome feature requests on dart-lang/dartdoc.

@kevmoo
Copy link
Member

kevmoo commented Feb 23, 2018

custom path for static assets (so we don't need to store it for each package version separately)

You likely want to have one copy for each version of dartdoc – in case the set of expected assets evolves from version to version

@isoos
Copy link
Collaborator Author

isoos commented Feb 23, 2018

--header puts extra content inside the <head> element (at the end of it). We want to customize (and override) the breadcrumbs with an extra logo and a link to the package page on pub (instead of the package homepage).

@isoos
Copy link
Collaborator Author

isoos commented Feb 23, 2018

custom path for static assets (so we don't need to store it for each package version separately)

You likely want to have one copy for each version of dartdoc – in case the set of expected assets evolves from version to version

Yes, but storing one copy is still better than count(PVs) copy :)

@kevmoo
Copy link
Member

kevmoo commented Feb 23, 2018 via email

@jcollins-g
Copy link

Re: header, OK, that makes sense. That belongs in it's own dartdoc issue too.

@jcollins-g jcollins-g mentioned this issue Feb 26, 2018
Open
@mit-mit mit-mit added this to the Backlog milestone Mar 19, 2018
@isoos
Copy link
Collaborator Author

isoos commented Jun 15, 2018

These issues are either resolved or a good workaround exists.

@isoos isoos closed this as completed Jun 15, 2018
@isoos isoos removed this from the Backlog milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @isoos @mit-mit @jcollins-g