Ignore uri_has_not_been_generated errors. #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still think that this is a bad precedent. |
kevmoo
requested changes
Jan 9, 2018
lib/src/analysis_options.dart
Outdated
| @@ -5,6 +5,8 @@ | |||
| const String analysisOptions = ''' | |||
| analyzer: | |||
| strong-mode: true | |||
| errors: | |||
| uri_has_not_been_generated: ignore | |||
There was a problem hiding this comment.
No!
I think the idea is: if the source package has this setup – then copy it.
Just whitelist uri_has_not_been_generated for pass-through
isoos
force-pushed
the
options_ignore
branch
2 times, most recently
from
3b4a668 to
927c956
Compare
kevmoo
approved these changes
Jan 10, 2018
|
|
||
| const _analyzerErrorKeys = const <String>['uri_has_not_been_generated']; | ||
|
|
||
| String customizeAnalysisOptions(String original, bool isFlutter) { |
There was a problem hiding this comment.
TODO: add an unit test for this – since it's more than a bit complicated
There was a problem hiding this comment.
@isoos – did you sanity check it w/ one of the samples we care about?
There was a problem hiding this comment.
Added tests, which caught an edge-case that was not caught with the sampling manual test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213