Files that import .template.dart files that are generated by Angular produce failures in Strong Mode analysis.

[nshahan]

Example:
https://pub.dartlang.org/packages/angular_components/versions/0.9.0-alpha%2B2#-analysis-tab-

The uri_has_not_been_generated: ignore option I have in the analysis_options.yaml file is not being used. https://github.com/dart-lang/angular_components/blob/master/analysis_options.yaml#L8

[kevmoo]

We use our own analysis_options.yaml file in pana – so folks can't just ignore all errors and skip our checks.

In-file ignores are your only option – now.

[isoos]

I'd argue the case that similarly to generated files for json_serializable, .template.dart files could be included in the package sources.

[kevmoo]

Ah! You'd think so, but in this case we're dealing w/ more than just boilerplate code. This is very different than json_serializable

…

On Mon, Jan 8, 2018 at 2:29 PM, István Soós ***@***.***> wrote: I'd argue the case that similarly to generated files for json_serializable, .template.dart files could be included in the package sources. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#213 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCilyQmFYLLGmvCNfB0zjRVcNH_dihks5tIpbYgaJpZM4RVELo> .

[nshahan]

@kevmoo So users can still avoid pana's check in this instance by placing the ignores everywhere they need them.

I'd propose that since this practice can be common, and will be required in the updated angular boostrapping it might make sense to allow that particular analysis option from the package to override pana's setting.

[matanlurey]

I agree with this being ignored in the default pana settings.

It won't hurt other customers.

[isoos]

This is very different than json_serializable

How so?

[kevmoo]

How so?

The generated templates are a product of the top-level package/app. They need to be synced w/ the version of angular, etc.

[kevmoo]

@matanlurey @nshahan – RE uri_has_not_been_generated – I think it's fine to whitelist some analysis options that can pass through. This is a good example.

@isoos – happy to chat/VC if you want more info

[isoos]

Is there a build process that generates these files? Maybe we could run standardized builds before analysis (that cannot be used to mess up with the analyzer environment).

[nshahan]

In this case the files are generated by angular when building the project.

[isoos]

In this case the files are generated by angular when building the project.

pana could trigger that build before analysis.

[kevmoo]

pana could trigger that build before analysis.

@isoos – there is no "build" for components. The build is part of an app.

[nshahan]

I am still seeing these errors when I publish new version of the package:
https://pub.dartlang.org/packages/angular_components/versions/0.9.0-alpha%2B5#-analysis-tab-

[isoos]

@nshahan thanks for flagging it again! We've had an embarrassing bug in pana, will be fixed with #248 which will be part of the 0.10.2 release.