Skip to content

Conversation

@robertbastian
Copy link
Contributor

@robertbastian robertbastian commented Oct 28, 2025

Fixes #1513

@sigurdm sigurdm requested a review from isoos October 28, 2025 12:15
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I had no clue we were so far behind.

@isoos are you happy?

If the Library as you received it specifies that a proxy can decide whether future versions of the GNU Lesser General Public License shall
apply, that proxy's public statement of acceptance of any version is permanent authorization for you to choose that version for the Library.

GNU GENERAL PUBLIC LICENSE
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

including the GPL in the LGPL is optional: https://spdx.org/licenses/LGPL-3.0-or-later.html

however this is not modeled by this code, so the similarity goes way down

@isoos
Copy link
Collaborator

isoos commented Oct 28, 2025

I think adding the additional licenses are great, but the LGPL additional content breaks the detection of them, and we have a sizeable amount of packages that already use LGPL-3.0. Let's revert the changes in those files, and keep the rest (esp. new files)!

@robertbastian
Copy link
Contributor Author

Define "those files"? LGPL-3.0 has a big diff, the other LGPLs don't. Some other files also have big diff (e.g. some CC-*). Should I revert all files with a diff, and only keep additions? Or just LGPT-3.0?

@isoos
Copy link
Collaborator

isoos commented Oct 28, 2025

Define "those files"? LGPL-3.0 has a big diff, the other LGPLs don't. Some other files also have big diff (e.g. some CC-*). Should I revert all files with a diff, and only keep additions? Or just LGPT-3.0?

To keep it simple, let's add only the new files and revert updated license texts. Optional, but maybe it would be worth to also add a simple test in license_test.dart for the one you are interested so we won't break it in the future.

#1105 is still relevant, we need to have better/reliable way to update the license texts without worrying on such add-on content, but that can come later.

@isoos isoos merged commit d2eb696 into dart-lang:master Oct 28, 2025
36 of 37 checks passed
@robertbastian robertbastian deleted the update-licenses branch October 28, 2025 13:14
@isoos
Copy link
Collaborator

isoos commented Oct 28, 2025

Thanks! It may take some time until this reaches pub.dev, probably next week the earliest.

@robertbastian
Copy link
Contributor Author

Do updates reprocess existing packages, or do I need to wait with my next publish?

@isoos
Copy link
Collaborator

isoos commented Oct 28, 2025

Do updates reprocess existing packages, or do I need to wait with my next publish?

The analysis will be repeated (on the latest and some other versions), no need for publishing a new version for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unicode-3.0 license not detected

3 participants