-
Notifications
You must be signed in to change notification settings - Fork 81
Closed
Labels
P1A high priority bug; for example, a single project is unusable or has many test failuresA high priority bug; for example, a single project is unusable or has many test failurespackage:hookspackage:hooks_runner
Description
@jonasfj and @mkustermann have pestered me enough about not using YAML for machine generated files. 😅
Good arguments to switch to JSON:
- Less ambiguities in the format that we have to deal with.
- Less dependencies in
package:native_assets_cli
(get rid of the yaml_edit package dependency).
Inconvenience to switch to JSON from YAML:
- Trouble shooting user problems and developing will require parsing JSON files as a human being.
Least breaking way to go to JSON:
- Keep supporting both YAML and JSON for the time being.
- Keep supporting both the JSON and YAML file path for build output for the time being.
- (Side note: @jonasfj Suggested we should not write the build output file to the output directory, so that it doesn't conflict with a possible asset file name.)
- (Side side note: @mkustermann suggested we might use different output directories for different asset types e.g. the dylibs go in to a different dir than jars. I'm not sure if that gains us anything.)
- (Side note: @jonasfj Suggested we should not write the build output file to the output directory, so that it doesn't conflict with a possible asset file name.)
Metadata
Metadata
Assignees
Labels
P1A high priority bug; for example, a single project is unusable or has many test failuresA high priority bug; for example, a single project is unusable or has many test failurespackage:hookspackage:hooks_runner