Skip to content

Conversation

@brianquinlan
Copy link
Collaborator

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label Nov 12, 2025
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
cupertino_http Breaking 2.3.0 2.4.0-wip 3.0.0
Got "2.4.0-wip" expected >= "3.0.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Coverage ⚠️
File Coverage
pkgs/cupertino_http/lib/src/cupertino_api.dart 💔 Not covered
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Changelog Entry
Package Changed Files
package:cupertino_http pkgs/cupertino_http/example/pubspec.yaml
pkgs/cupertino_http/lib/src/cupertino_api.dart
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart
pkgs/cupertino_http/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@liamappelbe
Copy link

Looking at your ffigen.yaml, is there a reason you're not setting exclude-all-by-default: true? All the analysis errors go away, and the code size goes from 100k lines to 33k, with this enabled. I'm glad you're not using it, since you found so many bugs, but it might make your life easier.

@brianquinlan
Copy link
Collaborator Author

Looking at your ffigen.yaml, is there a reason you're not setting exclude-all-by-default: true? All the analysis errors go away, and the code size goes from 100k lines to 33k, with this enabled. I'm glad you're not using it, since you found so many bugs, but it might make your life easier.

I made the strategic decision to not know about that option ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:cupertino_http Issues related to package:cupertino_http

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants