Use content-length header directly for dart:io #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How and why were these tests failing? Why does this change fix them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dart:iopath failed client tests wherecontent-lengthwas expected to be set. Thedart:htmlpath was successful for these tests already.One solution that seemed to imply a bug in
dart:iowas moving theheaders.setabove the setting ofcontentLength. This worked but this seems to be a better path since by defaultcontentLengthis -1 and if it is not set byMessagethen the behavior is the same. So the code is just deleted.Additionally it appears that in both Chrome and
dart:iothecontent-lengthheader is stripped when the GET method is called. It is not stripped for DELETE so the test was updated accordingly.