-
Notifications
You must be signed in to change notification settings - Fork 124
find as you type search #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
fa37be7
write a JSON index of all elements
sethladd cfc583c
a bit more about what encloses something
sethladd 5dce5ef
Merge branch 'master' of github.com:dart-lang/dartdoc into sl-find-as…
sethladd 272cc44
more work on find as you type
sethladd 3a0c2c4
search inside of strings
sethladd 6a51aec
style tweaks
sethladd 2f59b45
display what the suggestion is and what it is enclosed by, selecting …
sethladd bd6015c
Merge branch 'master' of github.com:dart-lang/dartdoc into sl-find-as…
sethladd e15b7e3
max 10 results, scroll the overflow
sethladd d3f0b6c
rename from review comments
sethladd 1b04a93
tweaks to styles
sethladd 9e92254
human-friendly type names for model elements
sethladd 2064f7d
Merge branch 'master' of github.com:dart-lang/dartdoc into sl-find-as…
sethladd 9a384e6
aligning text
sethladd fc70444
more style tweaks for mobile
sethladd 5b8299e
tweaks to styles
sethladd 3e5ba61
tweaks to styles
sethladd e954ad7
tweaking display of form
sethladd e607947
perform basic weighting of results
sethladd b9d0c67
shorter name breaks ties
sethladd c2596c0
search box is now slightly rounded
sethladd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear from the screenshots how this works on mobile. My sense is that smaller then some screen width, the search menu should display as wide as the screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't taken a look at mobile yet. That will certainly need another batch of fixes/changes.