find as you type search #799
Conversation
…a suggestion takes the user there
|
cc @keertip @devoncarew please take a look. I think this is good enough to try out and send feedback. Just tried it on the SDK. First thing I noticed: we need to rank somehow. Suggestions welcome. (e.g. does a class name outrank a field name?) |
| @@ -166,13 +168,34 @@ class HtmlGeneratorInstance { | |||
|
|
|||
| if (package != null) { | |||
| _generateDocs(); | |||
| _generateJson(); | |||
There was a problem hiding this comment.
Perhaps _generateIndex() or _generateSearchIndex()?
|
Looks great! A question about mobile behavior. |
|
Ready for review. It's not perfect, but I believe it's enough to get feedback on the actual behavior. Would like to do a build with this behavior and then tweak the ranking algorithm, based on feedback. This also fixes a few issues with paddings and lines. Search box is hidden for very small widths, will need to revisit. Should be visible for nearly all desktop users. cc @devoncarew |
|
It's a big one! Awesome to have this feature. 🔥 One bit of feedback on the UI. I'm not sure what the material design spec for search boxes is, but the square box doesn't say search to me. Consider putting a lgtm |
Sure, I'll give it a try. Thanks for the review! |
WIP
@devoncarew @keertip the plan is to generate a simple JSON file, enough to power a find-as-you-type search.
Do either of you have an opinion on how to implement the HTML bits for this? (e.g. found a good example?)