Document property types on the right like methods. #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the property name nice and flush left so it's easy to find.
|
I'm a fan. In fact, I think we had this at one point. The question is, does a property "return" a type, like a method/function does? Or is a property "a" type? (just thinking about the semantics of the arrow. maybe it's not an issue.) |
|
I think the semantics make sense. The left side of the arrow is what you write to invoke it and the right side is what you get back. The only difference between a property and a method is there no parentheses. |
|
lgtm |
sethladd
added a commit
that referenced
this pull request
Aug 7, 2015
Document property types on the right like methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the property name nice and flush left so it's easy to find.