access bootstrap files from web #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final String theme = | ||
| 'https://maxcdn.bootstrapcdn.com/bootstrap/3.3.1/css/bootstrap-theme.min.css'; | ||
|
|
||
| final String jsScript = |
There was a problem hiding this comment.
Keerti, fyi, I don't think any of the bits of bootstrap that dartdoc is using requires the JS file, just the main css file and the theme one.
|
Thanks Devon, removed the JS script tag. |
keertip
added a commit
that referenced
this pull request
Jan 6, 2015
access bootstrap files from web
|
Works for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sethladd
Access the bootstrap files from the web, instead of copying it from the package. This gets us around to running dartdoc using pub run.