Skip to content

Refactor class_test to use reflective_test_loader #3681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Feb 26, 2024

And move some common code to template_test_base.dart, and refer to shared code in class_test and extension_type_test.

Also, all of the existing test cases in class_test were about the "implementers" section, but I hadn't included that in the name, so I did that. Then I added some tests for constructors and instance methods showing up on a class's page. This is the groundwork for showing that macro-generated constructors and instance methods show up.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins requested a review from kallentu February 26, 2024 20:59
Copy link
Member

@kallentu kallentu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is great :)

@srawlins srawlins merged commit 5ea87b2 into dart-lang:main Feb 26, 2024
@srawlins srawlins deleted the refactor-class-test branch February 26, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants