Skip to content

Improve SubprocessException #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

srawlins
Copy link
Member

I was getting errors during a local flutter update-packages call, and SubprocessException was not really any help. This added information helps.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@@ -174,3 +176,21 @@ class SubprocessLauncher {

static final _quotables = RegExp(r'[ "\r\n\$]');
}

Copy link
Member

@kevmoo kevmoo Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not :D but I guess we could shave a few lines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of those folks who want to catch...uh...

You know, not a biggy. Just pondering...

@srawlins srawlins requested a review from kallentu February 26, 2024 17:04
@srawlins srawlins merged commit ec9c8e0 into dart-lang:main Feb 26, 2024
@srawlins srawlins deleted the subp-exception branch February 26, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants