Skip to content

Remove CallableElementType. #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Remove CallableElementType. #3668

merged 1 commit into from
Feb 22, 2024

Conversation

kallentu
Copy link
Member

Was looking at a bug and realized we don't use this code.

Removed CallableElementType which ended up removing the renderer.
showNames in the ParameterRenderer was only being set to false in this one place, so that's completely unused now too.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kallentu kallentu requested a review from srawlins February 22, 2024 00:31
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kallentu kallentu merged commit d5661fc into main Feb 22, 2024
@kallentu kallentu deleted the remove-call branch February 22, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants