Skip to content

Reintroduce remote linking file type assumption #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2023

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented May 30, 2023

#3413 accidentally dropped the assumption that all remote repositories were HTML. This breaks the Google sync in addition to being incompatible with the current realities of where things are hosted. If we want that assumption to be dropped we'll have to extend how we configure remote repositories.

@jcollins-g jcollins-g marked this pull request as ready for review May 30, 2023 17:46
@jcollins-g jcollins-g requested a review from srawlins May 30, 2023 17:46
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jcollins-g jcollins-g merged commit 950898f into dart-lang:main May 30, 2023
@jcollins-g jcollins-g deleted the file-structure-fix branch May 30, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants