Skip to content

Record rendering simplification #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Feb 21, 2023

Completes #3122.

Already approved, but for historical purposes:

This simplifies Record type rendering so it looks both more in line with Record type annotations as described in the spec and therefore, other types rendered by Dartdoc. We do this by dropping Record and the $n names.

Here are some sample screenshots:

Screenshot 2023-02-21 at 3 40 26 PM
Screenshot 2023-02-21 at 3 40 37 PM

@jcollins-g jcollins-g marked this pull request as ready for review February 21, 2023 23:42
@jcollins-g jcollins-g merged commit e4cdbd6 into dart-lang:master Feb 21, 2023
@jcollins-g jcollins-g deleted the record-rendering-simplification branch February 21, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants