Refactor search into a stateful class #3285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3272 by changing
initialize
into a stateful class. Really helps with readability, promotion, etc.This PR has a few little changes as well:
input
which each represent something totally differentselectedElement
was a nullable int, withnull
meaning "nothing is selected." I found a nullable hint very awkward to work with, seeing lots of expressions likeselectedElement! - 1
. I was able to make this a non-nullableint
, with-1
meaning "nothing is selected," and some helper functions like an extension onint
calledisBlurred
.