Skip to content

Re-enable sdk-analyzer job, but make it not failing #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Re-enable sdk-analyzer job, but make it not failing #2864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2dcbc1
Remove extra annotate_overrides; its included in recommended.yaml
srawlins Dec 14, 2021
ce841f3
Re-enable zombie sdk-analyzer, but catch failures
srawlins Dec 14, 2021
87d1a80
indentation
srawlins Dec 14, 2021
f2a93ac
Merge branch 'master' into no-annotate
srawlins Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
matrix:
os: [ubuntu-latest]
sdk: [dev, stable]
job: [main, flutter, packages, sdk-docs]
job: [main, flutter, sdk-analyzer, packages, sdk-docs]
include:
- os: macos-latest
sdk: dev
Expand All @@ -34,8 +34,8 @@ jobs:
# results.
- sdk: stable
job: flutter
#- sdk: stable
# job: sdk-analyzer
- sdk: stable
job: sdk-analyzer
- sdk: stable
job: sdk-docs

Expand Down
1 change: 0 additions & 1 deletion analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ analyzer:
linter:
rules:
always_declare_return_types: true
annotate_overrides: true
avoid_dynamic_calls: true
avoid_single_cascade_in_expression_statements: true
avoid_unused_constructor_parameters: true
Expand Down
1 change: 0 additions & 1 deletion analysis_options_presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ analyzer:
linter:
rules:
always_declare_return_types: true
annotate_overrides: true
avoid_dynamic_calls: true
avoid_single_cascade_in_expression_statements: true
avoid_unused_constructor_parameters: true
Expand Down
12 changes: 9 additions & 3 deletions tool/grind.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,9 +544,15 @@ Future<void> testWithAnalyzerSdk() async {
var sdkDartdoc = await createSdkDartdoc();
var defaultGrindParameter =
Platform.environment['DARTDOC_GRIND_STEP'] ?? 'test';
await launcher.runStreamed(
sdkBin('pub'), ['run', 'grinder', defaultGrindParameter],
workingDirectory: sdkDartdoc);
// TODO(srawlins): Re-enable sdk-analyzer when dart_style is published using
// analyzer 3.0.0.
try {
await launcher.runStreamed(
sdkBin('pub'), ['run', 'grinder', defaultGrindParameter],
workingDirectory: sdkDartdoc);
} catch (e, st) {
print('Warning: SDK analyzer job threw "$e":\n$st');
}
}

Future<List<Map<Object, Object>>> _buildSdkDocs(
Expand Down