Skip to content

Skip sdk-analyzer job #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
matrix:
os: [ubuntu-latest]
sdk: [dev, stable]
job: [main, flutter, sdk-analyzer, packages, sdk-docs]
job: [main, flutter, packages, sdk-docs]
include:
- os: macos-latest
sdk: dev
Expand All @@ -34,8 +34,8 @@ jobs:
# results.
- sdk: stable
job: flutter
- sdk: stable
job: sdk-analyzer
#- sdk: stable
# job: sdk-analyzer
- sdk: stable
job: sdk-docs

Expand Down
1 change: 1 addition & 0 deletions testing/test_package/lib/features/nullable_elements.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ void set nullableSetter(String? value) {
}

/// This should have return type of `Future?`.
// ignore: unnecessary_question_mark
dynamic? oddAsyncFunction() async {}

/// This should also have return type of `Future?`.
Expand Down
1 change: 1 addition & 0 deletions testing/test_package/lib/features/opt_out_of_nnbd.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@

library opt_out_of_nnbd;

// ignore: dead_code
String notOptedIn = false ? 'hi' : null;
2 changes: 2 additions & 0 deletions testing/test_package/lib/src/somelib.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@ class ExtendedBaseReexported extends BaseReexported {}

/// A private extension.
extension _Unseen on Object {
// ignore: unused_element
void doYouSeeMe() {}
}

/// An extension without a name
extension on List {
// ignore: unused_element
void somethingNew() {}
}

Expand Down
6 changes: 4 additions & 2 deletions tool/grind.dart
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,10 @@ void analyzeTestPackages() async {
workingDirectory: testPackagePath,
);
await SubprocessLauncher('analyze-test-package').runStreamed(
sdkBin('dartanalyzer'),
['.'],
sdkBin('dart'),
// TODO(srawlins): Analyze the whole directory by ignoring the pubspec
// reports.
['analyze', 'lib'],
workingDirectory: testPackagePath,
);
}
Expand Down