Merge main branch to NNBD to pick up MockSdk changes #2847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dart-lang#2845) * Update to analyzer 2.7.0, use createMockSdk() and FolderBasedDartSdk. * format
srawlins
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some sort of strange interaction with MemoryResourceProvider on windows systems that is difficult to debug without a windows system. I suspect it is because they have path contexts initialized with capital letter drive paths, which are not actually canonical. There is no way to override this, so just disable the tests for now and investigate a fix in analyzer.
This only became apparent after the MockSdk changes, and a change to make the input directory non-nullable.