Skip to content

Fix link to extensions #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Fix link to extensions #2717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c69dee6
Fix link to extensions
Jul 13, 2021
05741ad
Merge branch 'master' into patch-1
jcollins-g Aug 6, 2021
3c21949
Rebuild AOT templates
jcollins-g Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/generator/templates.aot_renderers_for_html.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9640,7 +9640,7 @@ String renderSidebarForLibrary<T extends _i17.Documentable>(
buffer.write('''
<li class="section-title"><a href="''');
buffer.write(context1.href.toString());
buffer.write('''#extension">Extensions</a></li>''');
buffer.write('''#extensions">Extensions</a></li>''');
var context4 = context1.publicExtensionsSorted;
if (context4 != null) {
for (var context5 in context4) {
Expand Down
2 changes: 1 addition & 1 deletion lib/templates/html/_sidebar_for_library.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{{/hasPublicClasses}}

{{#hasPublicExtensions}}
<li class="section-title"><a href="{{{href}}}#extension">Extensions</a></li>
<li class="section-title"><a href="{{{href}}}#extensions">Extensions</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @geisterfurz007! Rebuilt the aot renderer using grind build so this can land.

{{#publicExtensionsSorted}}
<li>{{{ linkedName }}}</li>
{{/publicExtensionsSorted}}
Expand Down