Fix link to extensions #2717
Merged
Fix link to extensions #2717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Will add @srawlins for review. |
jcollins-g
approved these changes
Aug 6, 2021
| @@ -8,7 +8,7 @@ | |||
| {{/hasPublicClasses}} | |||
|
|
|||
| {{#hasPublicExtensions}} | |||
| <li class="section-title"><a href="{{{href}}}#extension">Extensions</a></li> | |||
| <li class="section-title"><a href="{{{href}}}#extensions">Extensions</a></li> | |||
There was a problem hiding this comment.
Thanks, @geisterfurz007! Rebuilt the aot renderer using grind build so this can land.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sidebar currently links to
#extensiondartdoc/lib/templates/html/_sidebar_for_library.html
Line 11 in c9621b9
While the matching id is
extensions:dartdoc/lib/templates/html/library.html
Line 37 in c9621b9
This PR matches the link in the sidebar to the ID in the library page.