Skip to content

Fix constructors and type parameters in the new lookup code #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 15, 2021

Conversation

jcollins-g
Copy link
Contributor

This is a batch of small changes and accompanying tests that correct the following issues in the new lookup code:

  • Finding TypeParameters was inappropriately logged as a non-equivalent result. Since they don't actually link to anything, it's not important that we found one when we didn't in the old code.
  • The allowDefaultConstructors boolean was not set correctly now that we actually have parse nodes, this is now fixed.
  • Ambiguity between requiring a callable and requiring a constructor is fixed in the new code; it works better than the old one did now.
  • Consistently look up field formal parameters instead of doing so accidentally.
  • All constructor lookups have been overhauled, with names appropriate for the new lookup system inserted in the referenceChildren tables.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jun 14, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 57.658% when pulling d148222 on jcollins-g:constructor-lookup-fix into e5e596c on dart-lang:master.

@jcollins-g jcollins-g requested a review from srawlins June 15, 2021 00:05
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jcollins-g jcollins-g merged commit 9ef58f2 into dart-lang:master Jun 15, 2021
@jcollins-g jcollins-g deleted the constructor-lookup-fix branch June 15, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants